Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote: > > However, all the code that is doing direct accesses using '&' has to > > change to make that work - so I've converted it all to using accessors so > > that I only have to change the header file, except that the patch to do > > that crossed with a cifs patch that added more direct accesses, IIRC. > > But I still don't really see the point of the wrappers. Maybe they are > ok as a migration strategy, but in that case this patch mostly makes > sense as part of the series only. Can we at least push this patch? All the other users have been converted to use the wrappers upstream, just not these because the patch adding them crossed with the wrapper patch. Then everything is consistent (unless more unwrapped users got added in the merge window). David
