On Thu, Nov 21, 2019 at 08:07:25AM -0800, Christoph Hellwig wrote: > > However, all the code that is doing direct accesses using '&' has to change to > > make that work - so I've converted it all to using accessors so that I only > > have to change the header file, except that the patch to do that crossed with > > a cifs patch that added more direct accesses, IIRC. > > But I still don't really see the point of the wrappers. Maybe they are > ok as a migration strategy, but in that case this patch mostly makes > sense as part of the series only. Wrappers have one benefit, though - they are greppable. 'type' really isn't. _IF_ we go for "use that field directly", let's rename the damn field.
