More fallout from tree-wide audit for ->d_inode/->d_flags barriers
use. Basically, the problem is that negative pinned dentries require
careful treatment - unless ->d_lock is locked or parent is held at least
shared, another thread can make them positive right under us.
Most of the uses turned out to be safe - the main surprises as
far as filesystems are concerned were
* race in dget_parent() fastpath, that might end up with the
caller observing the returned dentry _negative_, due to insufficient
barriers. It is positive in memory, but we could end up seeing
the wrong value of ->d_inode in CPU cache. Fixed.
* manual checks that result of lookup_one_len_unlocked() is
positive (and rejection of negatives). Again, insufficient barriers
(we might end up with inconsistent observed values of ->d_inode and
->d_flags). Fixed by switching to a new primitive that does the
checks itself and returns ERR_PTR(-ENOENT) instead of a negative
dentry. That way we get rid of boilerplate converting negatives
into ERR_PTR(-ENOENT) in the callers and have a single place to
deal with the barrier-related mess - inside fs/namei.c rather than
in every caller out there.
The guts of pathname resolution *do* need to be careful -
the race found by Ritesh is real, as well as several similar
races. Fortunately, it turns out that we can take care of that
with fairly local changes in there.
The tree-wide audit had not been fun, and I hate the idea of
repeating it. I think the right approach would be to annotate the
places where we are _not_ guaranteed ->d_inode/->d_flags stability
and have sparse catch regressions. But I'm still not sure what would
be the least invasive way of doing that and it's clearly the next
cycle fodder.
The following changes since commit 3e5aeec0e267d4422a4e740ce723549a3098a4d1:
cramfs: fix usage on non-MTD device (2019-11-23 21:44:49 -0500)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git fixes
for you to fetch changes up to 2fa6b1e01a9b1a54769c394f06cd72c3d12a2d48:
fs/namei.c: fix missing barriers when checking positivity (2019-11-15 13:49:04 -0500)
----------------------------------------------------------------
Al Viro (4):
fs/namei.c: pull positivity check into follow_managed()
new helper: lookup_positive_unlocked()
fix dget_parent() fastpath race
fs/namei.c: fix missing barriers when checking positivity
fs/cifs/cifsfs.c | 7 +------
fs/dcache.c | 6 ++++--
fs/debugfs/inode.c | 6 +-----
fs/kernfs/mount.c | 2 +-
fs/namei.c | 56 ++++++++++++++++++++++++++++----------------------
fs/nfsd/nfs3xdr.c | 4 +---
fs/nfsd/nfs4xdr.c | 11 +---------
fs/overlayfs/namei.c | 24 ++++++++--------------
fs/quota/dquot.c | 7 +------
include/linux/dcache.h | 5 +++++
include/linux/namei.h | 1 +
11 files changed, 56 insertions(+), 73 deletions(-)
