On Tue, Dec 03, 2019 at 07:36:29AM +0000, Trond Myklebust wrote: > On Mon, 2019-12-02 at 08:05 +1100, Dave Chinner wrote: > > On Wed, Nov 27, 2019 at 12:21:36PM -0800, Darrick J. Wong wrote: > > > On Wed, Nov 27, 2019 at 06:38:46PM +0000, Trond Myklebust wrote: > > > > Hi all > > > > > > > > A quick question about clone_range() and guarantees around > > > > metadata > > > > stability. > > > > > > > > Are users required to call fsync/fsync_range() after calling > > > > clone_range() in order to guarantee that the cloned range > > > > metadata is > > > > persisted? > > > > > > Yes. > > > > > > > I'm assuming that it is required in order to guarantee that > > > > data is persisted. > > > > > > Data and metadata. XFS and ocfs2's reflink implementations will > > > flush > > > the page cache before starting the remap, but they both require > > > fsync to > > > force the log/journal to disk. > > > > So we need to call xfs_fs_nfs_commit_metadata() to get that done > > post vfs_clone_file_range() completion on the server side, yes? > > > > I chose to implement this using a full call to vfs_fsync_range(), since > we really do want to ensure data stability as well. Consider, for > instance, the case where client A is running an application, and client > B runs vfs_clone_file_range() in order to create a point in time > snapshot of the file for disaster recovery purposes... Data stability should already be handled by vfs_clone_file_range() followed by ->commit_metadata. Clone requires local filesystem side data stability to guarantee the atomicity of the clone operation. Hence we lock out concurrent modifications to both the source and desination files, sync any dirty data over the source and destination ranges of the clone, and only then do we do the metadata modification. See generic_remap_file_range_prep(). So, AFAICT, a post-vfs_clone_file_range() call to ->commit_metadata is all that is necessary to force the metadata to stable storage and the corresponding disk cache flush will guarantee that both data and metadata are on stable storage.... Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx
