Re: [PATCH 11/21] erofs: use dsb instead of layout for ondisk super_block

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 11/21] erofs: use dsb instead of layout for ondisk super_block
From: Gao Xiang <gaoxiang25@xxxxxxxxxx>
Date: Mon, 2 Sep 2019 20:15:19 +0800
Cc: Gao Xiang <hsiangkao@xxxxxxx>, Chao Yu <yuchao0@xxxxxxxxxx>, "Greg Kroah-Hartman" <gregkh@xxxxxxxxxxxxxxxxxxx>, <linux-fsdevel@xxxxxxxxxxxxxxx>, <devel@xxxxxxxxxxxxxxxxxxxx>, <linux-erofs@xxxxxxxxxxxxxxxx>, Chao Yu <chao@xxxxxxxxxx>
In-reply-to: <20190902121234.GJ15931@infradead.org>
User-agent: Mutt/1.9.4 (2018-02-28)

Hi Christoph,

On Mon, Sep 02, 2019 at 05:12:34AM -0700, Christoph Hellwig wrote:
> > +	dsb = (struct erofs_super_block *)((u8 *)bh->b_data +
> > +					   EROFS_SUPER_OFFSET);
> 
> Not new in this patch, but that u8 cast shouldn't be needed.

Yes, thanks and will fix it...

Thanks,
Gao Xiang

References:
- [PATCH v6 00/24] erofs: promote erofs from staging
  - From: Gao Xiang
- [PATCH 00/21] erofs: patchset addressing Christoph's comments
  - From: Gao Xiang
- [PATCH 11/21] erofs: use dsb instead of layout for ondisk super_block
  - From: Gao Xiang
- Re: [PATCH 11/21] erofs: use dsb instead of layout for ondisk super_block
  - From: Christoph Hellwig

Prev by Date: Re: [PATCH 07/21] erofs: use erofs_inode naming
Next by Date: Re: [PATCH 12/21] erofs: kill verbose debug info in erofs_fill_super
Previous by thread: Re: [PATCH 11/21] erofs: use dsb instead of layout for ondisk super_block
Next by thread: [PATCH 12/21] erofs: kill verbose debug info in erofs_fill_super
Index(es):
- Date
- Thread

[Index of Archives] [Linux Ext4 Filesystem] [Union Filesystem] [Filesystem Testing] [Ceph Users] [Ecryptfs] [AutoFS] [Kernel Newbies] [Share Photos] [Security] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux Cachefs] [Reiser Filesystem] [Linux RAID] [Samba] [Device Mapper] [CEPH Development]