On Fri 30-08-19 15:48:04, Steven Rostedt wrote: > On Thu, 13 Jun 2019 19:53:25 +0300 > Amir Goldstein <amir73il@xxxxxxxxx> wrote: > > > On Sun, May 26, 2019 at 5:34 PM Amir Goldstein <amir73il@xxxxxxxxx> wrote: > > > > > > This will allow generating fsnotify delete events after the > > > fsnotify_nameremove() hook is removed from d_delete(). > > > > > > Cc: Steven Rostedt <rostedt@xxxxxxxxxxx> > > > Signed-off-by: Amir Goldstein <amir73il@xxxxxxxxx> > > > > Hi Steven, > > > > Would you be able to provide an ACK on this patch? > > We need to add those explicit fsnotify hooks to match the existing > > fsnotify_create/mkdir hooks in tracefs, because > > the hook embedded inside d_delete() is going away [1]. > > > > Thanks, > > Amir. > > > > [1] https://lore.kernel.org/linux-fsdevel/20190526143411.11244-1-amir73il@xxxxxxxxx/ > > > > Sorry, this got lost in my INBOX. I see it was already merged, but I > would have acked it ;-) Thanks for the dealayed ack. I've used my best judgement and decided that you probably would not object when pushing the patch :). Honza -- Jan Kara <jack@xxxxxxxx> SUSE Labs, CR