On Sun, May 26, 2019 at 5:34 PM Amir Goldstein <amir73il@xxxxxxxxx> wrote: > > This will allow generating fsnotify delete events after the > fsnotify_nameremove() hook is removed from d_delete(). > > Cc: Steven Rostedt <rostedt@xxxxxxxxxxx> > Signed-off-by: Amir Goldstein <amir73il@xxxxxxxxx> Hi Steven, Would you be able to provide an ACK on this patch? We need to add those explicit fsnotify hooks to match the existing fsnotify_create/mkdir hooks in tracefs, because the hook embedded inside d_delete() is going away [1]. Thanks, Amir. [1] https://lore.kernel.org/linux-fsdevel/20190526143411.11244-1-amir73il@xxxxxxxxx/ > --- > fs/tracefs/inode.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/fs/tracefs/inode.c b/fs/tracefs/inode.c > index 7098c49f3693..497a8682b5b9 100644 > --- a/fs/tracefs/inode.c > +++ b/fs/tracefs/inode.c > @@ -509,9 +509,12 @@ static int __tracefs_remove(struct dentry *dentry, struct dentry *parent) > switch (dentry->d_inode->i_mode & S_IFMT) { > case S_IFDIR: > ret = simple_rmdir(parent->d_inode, dentry); > + if (!ret) > + fsnotify_rmdir(parent->d_inode, dentry); > break; > default: > simple_unlink(parent->d_inode, dentry); > + fsnotify_unlink(parent->d_inode, dentry); > break; > } > if (!ret) > -- > 2.17.1 >
