On Wed, Aug 14, 2019 at 01:01:50PM +0200, Carlos Maiolino wrote: > Hey folks, > > > All errors (new ones prefixed by >>): > > > > fs/ioctl.c: In function 'ioctl_fibmap': > > >> fs/ioctl.c:68:10: error: implicit declaration of function 'bmap'; did you mean 'kmap'? [-Werror=implicit-function-declaration] > > Any of you guys may have a better idea on how to fix this? > > Essentially, this happens when CONFIG_BLOCK is not set, and although I don't > really see a hard requirement to have bmap() exported only when CONFIG_BLOCK is > set, at the same time, I don't see use for bmap() if CONFIG_BLOCK is not set. > > So, I'm in a kind of a chicken-egg problem. > > I am considering to just remove the #ifdef CONFIG_BLOCK / #endif from the bmap() > declaration. This will fix the warning, and I don't see any side effects. What > you guys think? Just provide an inline !CONFIG_BLOCK stub for bmap() in fs.h that always returns -EINVAL.
