Hey folks,
> All errors (new ones prefixed by >>):
>
> fs/ioctl.c: In function 'ioctl_fibmap':
> >> fs/ioctl.c:68:10: error: implicit declaration of function 'bmap'; did you mean 'kmap'? [-Werror=implicit-function-declaration]
Any of you guys may have a better idea on how to fix this?
Essentially, this happens when CONFIG_BLOCK is not set, and although I don't
really see a hard requirement to have bmap() exported only when CONFIG_BLOCK is
set, at the same time, I don't see use for bmap() if CONFIG_BLOCK is not set.
So, I'm in a kind of a chicken-egg problem.
I am considering to just remove the #ifdef CONFIG_BLOCK / #endif from the bmap()
declaration. This will fix the warning, and I don't see any side effects. What
you guys think?
> error = bmap(inode, &block);
> ^~~~
> kmap
> cc1: some warnings being treated as errors
>
> vim +68 fs/ioctl.c
>
> 53
> 54 static int ioctl_fibmap(struct file *filp, int __user *p)
> 55 {
> 56 struct inode *inode = file_inode(filp);
> 57 int error, ur_block;
> 58 sector_t block;
> 59
> 60 if (!capable(CAP_SYS_RAWIO))
> 61 return -EPERM;
> 62
> 63 error = get_user(ur_block, p);
> 64 if (error)
> 65 return error;
> 66
> 67 block = ur_block;
> > 68 error = bmap(inode, &block);
> 69
> 70 if (error)
> 71 ur_block = 0;
> 72 else
> 73 ur_block = block;
> 74
> 75 error = put_user(ur_block, p);
> 76
> 77 return error;
> 78 }
> 79
>
> ---
> 0-DAY kernel test infrastructure Open Source Technology Center
> https://lists.01.org/pipermail/kbuild-all Intel Corporation
--
Carlos
