On Tue, May 06, 2008 at 11:13:37AM +0200, Miklos Szeredi wrote:
> - error = -EPERM;
> - if (IS_APPEND(inode))
> - goto mnt_drop_write_and_out;
> -
> error = get_write_access(inode);
> if (error)
> goto mnt_drop_write_and_out;
errno change and worse than that - we
a) get different errno with append-only file mmaped shared
b) break_lease() happening, despite the file being append-only
> @@ -321,10 +317,6 @@ static long do_sys_ftruncate(unsigned in
> if (small && length > MAX_NON_LFS)
> goto out_putf;
>
> - error = -EPERM;
> - if (IS_APPEND(inode))
> - goto out_putf;
> -
> error = locks_verify_truncate(inode, file, length);
Again, errno change...
> @@ -1639,8 +1639,6 @@ int may_open(struct nameidata *nd, int a
> if (IS_APPEND(inode)) {
> if ((flag & FMODE_WRITE) && !(flag & O_APPEND))
> return -EPERM;
> - if (flag & O_TRUNC)
> - return -EPERM;
> }
Bogus break_lease() following that...
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
