Re: [patch 13/24] vfs: utimes cleanup

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> > + * do_futimesat - change times on filename
> 
> > +int do_utimes(int dfd, char __user *filename, struct timespec *times, int flags)
> 
> Erm...  Is there any reason to
> 	* have do_utimes() used anywhere
> 	* _not_ have do_futimesat() called "do_utimes"?

Review ping-pong.  My original patch did that, and Christoph didn't
like it.  I don't care that much actually, one thing I like better in
the second version is to have a separate function for the path lookup
thing (now called do_utimes(), but it could be renamed to
name_utimes() or whatever).

Miklos
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]
  Powered by Linux