On Wed, Apr 24, 2019 at 5:22 PM David Howells <dhowells@xxxxxxxxxx> wrote: > > Miklos Szeredi <miklos@xxxxxxxxxx> wrote: > > > Should I be applying this, together with the vfs dependencies? Or > > will you take care of these? > > I'm hoping Al will take the entire series. > > > One minor comment is that fuse conventionally uses "struct fuse_conn > > *fc", so "struct fs_context *fc" is confusing here. There's one place > > you use "struct fs_context *fsc", which seems the right thing to do > > for all the cases. > > Except in ceph, where "struct ceph_fs_client *fsc" is a common thing... I'd be happy if it was consistently "struct fs_context *fsc" in just fuse/inode.c. Thanks, Miklos