On Thu, Mar 28, 2019 at 12:46 AM David Howells <dhowells@xxxxxxxxxx> wrote: > > Convert the fuse filesystem to the new internal mount API as the old > one will be obsoleted and removed. This allows greater flexibility in > communication of mount parameters between userspace, the VFS and the > filesystem. > > See Documentation/filesystems/mount_api.txt for more information. Should I be applying this, together with the vfs dependencies? Or will you take care of these? One minor comment is that fuse conventionally uses "struct fuse_conn *fc", so "struct fs_context *fc" is confusing here. There's one place you use "struct fs_context *fsc", which seems the right thing to do for all the cases. Thanks, Miklos