Re: [PATCH 1/2] gfs2: Convert gfs2 to fs_context

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Andrew Price <anprice@xxxxxxxxxx> wrote:

> sget() is still used instead of sget_fc() as there doesn't seem to be an
> obvious replacement for the bdev pointer propagation to the test/set
> functions (yet?)

Umm...  What about the fs_context struct?  Why can't that be used to propagate
the bdev pointer?  That's kind of what it's for...

	struct super_block *sget_fc(
		struct fs_context *fc,
		int (*test)(struct super_block *, struct fs_context *),
		int (*set)(struct super_block *, struct fs_context *))

It looks like you should be able to stash the bdev pointer in the gfs2_args
struct.

> +	fsparam_s32    ("commit",             Opt_commit),
> +	fsparam_s32    ("statfs_quantum",     Opt_statfs_quantum),
> +	fsparam_s32    ("statfs_percent",     Opt_statfs_percent),

Why s32?  Why not u32?

David



[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]

  Powered by Linux