On Mon, Mar 11, 2019 at 08:48:30PM +0100, Christoph Hellwig wrote: > On Sun, Mar 10, 2019 at 07:08:22AM +0000, Al Viro wrote: > > From: Al Viro <viro@xxxxxxxxxxxxxxxxxx> > > > > makes for somewhat cleaner control flow in __io_submit_one() > > > > Signed-off-by: Al Viro <viro@xxxxxxxxxxxxxxxxxx> > > I wonder if we should even bother keeping __io_submit_one. Splitting > that out was prep work from Jens for something that eventually turned > into io_uring. *shrug* I think it's a bit easier to keep track of control flow - failure exits are simpler that way.