Re: [PATCH 8/8] aio: move sanity checks and request allocation to io_submit_one()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Al Viro <viro@xxxxxxxxxxxxxxxxxx>
Subject: Re: [PATCH 8/8] aio: move sanity checks and request allocation to io_submit_one()
From: Christoph Hellwig <hch@xxxxxx>
Date: Mon, 11 Mar 2019 20:48:30 +0100
Cc: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>, Eric Dumazet <eric.dumazet@xxxxxxxxx>, David Miller <davem@xxxxxxxxxxxxx>, Jason Baron <jbaron@xxxxxxxxxx>, kgraul@xxxxxxxxxxxxx, ktkhai@xxxxxxxxxxxxx, kyeongdon.kim@xxxxxxx, Linux List Kernel Mailing <linux-kernel@xxxxxxxxxxxxxxx>, Netdev <netdev@xxxxxxxxxxxxxxx>, pabeni@xxxxxxxxxx, syzkaller-bugs@xxxxxxxxxxxxxxxx, xiyou.wangcong@xxxxxxxxx, Christoph Hellwig <hch@xxxxxx>, zhengbin <zhengbin13@xxxxxxxxxx>, bcrl@xxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, linux-aio@xxxxxxxxx, houtao1@xxxxxxxxxx, yi.zhang@xxxxxxxxxx
In-reply-to: <20190310070822.11564-8-viro@ZenIV.linux.org.uk>
User-agent: Mutt/1.5.17 (2007-11-01)

On Sun, Mar 10, 2019 at 07:08:22AM +0000, Al Viro wrote:
> From: Al Viro <viro@xxxxxxxxxxxxxxxxxx>
> 
> makes for somewhat cleaner control flow in __io_submit_one()
> 
> Signed-off-by: Al Viro <viro@xxxxxxxxxxxxxxxxxx>

I wonder if we should even bother keeping __io_submit_one.  Splitting
that out was prep work from Jens for something that eventually turned
into io_uring.

Follow-Ups:
- Re: [PATCH 8/8] aio: move sanity checks and request allocation to io_submit_one()
  - From: Al Viro

References:
- Re: [PATCH 1/8] aio: make sure file is pinned
  - From: Al Viro
- [PATCH 1/8] pin iocb through aio.
  - From: Al Viro
- [PATCH 8/8] aio: move sanity checks and request allocation to io_submit_one()
  - From: Al Viro

Prev by Date: Re: [PATCH] x86: Deprecate a.out support
Next by Date: Re: [PATCH 4/8] Fix aio_poll() races
Previous by thread: [PATCH 8/8] aio: move sanity checks and request allocation to io_submit_one()
Next by thread: Re: [PATCH 8/8] aio: move sanity checks and request allocation to io_submit_one()
Index(es):
- Date
- Thread

[Index of Archives] [Linux Ext4 Filesystem] [Union Filesystem] [Filesystem Testing] [Ceph Users] [Ecryptfs] [AutoFS] [Kernel Newbies] [Share Photos] [Security] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux Cachefs] [Reiser Filesystem] [Linux RAID] [Samba] [Device Mapper] [CEPH Development]