On Thu, Feb 21, 2019 at 11:47:49AM -0600, Eric Sandeen wrote: > On 2/21/19 9:18 AM, Luis Chamberlain wrote: > > On Wed, Feb 20, 2019 at 05:35:04PM -0600, Eric Sandeen wrote: > >> Here's a pretty hacky test script to test this code via > >> ip_local_reserved_ports > > > > Thanks Eric! > > > > So /proc/sys/net/ipv4/ip_local_reserved_ports is a production knob, and > > if we wanted to stress test it with a selftest it could break other self > > tests or change the system behaviour. Because of this we have now have > > lib/test_sysctl.c, and we test this with the script: > > > > tools/testing/selftests/sysctl/sysctl.sh > > > > Any chance you can extend lib/test_sysctl.c with a new respective bitmap > > knob, > > Done Thanks! > > and add a respective test? This will ensure we don't regress > > later. 0-day runs sysctl.sh so it should catch any regressions in the > > future. > > As you know, learning somebody else's test harness infra is a PITA. ;) > Can you find me off-list and give me a hand with this? Sure, its actually quite simple, just as root, run the script. Luis
