On Wed, Feb 20, 2019 at 05:35:04PM -0600, Eric Sandeen wrote: > Here's a pretty hacky test script to test this code via > ip_local_reserved_ports Thanks Eric! So /proc/sys/net/ipv4/ip_local_reserved_ports is a production knob, and if we wanted to stress test it with a selftest it could break other self tests or change the system behaviour. Because of this we have now have lib/test_sysctl.c, and we test this with the script: tools/testing/selftests/sysctl/sysctl.sh Any chance you can extend lib/test_sysctl.c with a new respective bitmap knob, and add a respective test? This will ensure we don't regress later. 0-day runs sysctl.sh so it should catch any regressions in the future. If you can think of other ways to test the knob that would be great too. Luis
