On Thu, 2019-02-14 at 11:55 +-0100, Johannes Thumshirn wrote: +AD4 On Wed, Feb 13, 2019 at 01:07:54PM -0500, Theodore Y. Ts'o wrote: +AD4 +AD4 Also, there are expectations about minimum versions of bash that can +AD4 +AD4 be supported+ADs but there aren't necessarily for other components such +AD4 +AD4 as nvme-cli, and I suspect that it is due to the use of a overly new +AD4 +AD4 version of nvme-cli from its git tree. Is that supposed to work, or +AD4 +AD4 should I constrain myself to whatever version is being shipped in +AD4 +AD4 Fedora or some other reference distribution? More generally, what is +AD4 +AD4 the overall expectations that should be expected? xfstests has some +AD4 +AD4 extremely expansive set of sed scripts to normalize shell script +AD4 +AD4 output to make xfstests extremely portable+ADs will patches along similar +AD4 +AD4 lines something that we should be doing for blktests? +AD4 +AD4 I think this is the root cause of the problems you've sent out mails for this +AD4 week. A lot of blktests test need filtering. See +AFs-1+AF0 as an example. +AD4 +AD4 +AFs-1+AF0 https://github.com/osandov/blktests/pull/34 Hi Johannes, Output of tools like nvme-cli is not an ABI although an ABI is what is required to make blktests work reliably. One possible approach is to modify nvme-cli such that it has two output formats: one output format that is intended for humans and another that is easy to parse by software. I think we should consider that approach and compare it to using sed scripts. Bart.
