On 1/28/19 7:29 AM, Christoph Hellwig wrote: >> +struct file *fget_many(unsigned int fd, unsigned int refs) >> +{ >> + return __fget(fd, FMODE_PATH, refs); >> +} >> + >> struct file *fget(unsigned int fd) >> { >> - return __fget(fd, FMODE_PATH); >> + return fget_many(fd, 1); > > I'd still prefer removing the double indirection in this call, but > I know you disagree. Not a big deal, I can kill it. -- Jens Axboe