> +struct file *fget_many(unsigned int fd, unsigned int refs) > +{ > + return __fget(fd, FMODE_PATH, refs); > +} > + > struct file *fget(unsigned int fd) > { > - return __fget(fd, FMODE_PATH); > + return fget_many(fd, 1); I'd still prefer removing the double indirection in this call, but I know you disagree. > } > EXPORT_SYMBOL(fget); > > struct file *fget_raw(unsigned int fd) > { > - return __fget(fd, 0); > + return __fget(fd, 0, 1); > } > EXPORT_SYMBOL(fget_raw); Especially as we already avoid it here.. Otherwise looks fine to me: Reviewed-by: Christoph Hellwig <hch@xxxxxx>