On Mon, Jan 14, 2019 at 06:56:16PM +0100, Andreas Grünbacher wrote: > Yes, locking. The fiemap_fill_cb callback hack still makes the fiemap > interface much uglier though. So couldn't the existing iop be used to > fill a kernel buffer in a way similar to what functions like > kernel_readv do? That would at least avoid wrecking an existing > interface. There is no file system visible change at all, the callback happens all behind the back. We could do a less extensible union based version, but I see absolutely no upside in that. set_fs as in kernel_readv needs to go away, so no new users should be added.
