On Thu, Dec 06, 2018 at 07:56:02PM +0100, Andreas Grünbacher wrote: > Hi, > > Am Mi., 5. Dez. 2018 um 10:18 Uhr schrieb Carlos Maiolino > <cmaiolino@xxxxxxxxxx>: > > This is the second version of the complete series with the goal to remove ->bmap > > interface completely, in lieu of FIEMAP. > > I'm not thrilled by this approach. How about exposing the iomap > operations at the vfs layer (for example, in the super block) and > implementing bmap on top of that instead? > Well, the idea is exactly to get rid of bmap, not reimplement it. We can use the same operation for both cases (fiemap+fibmap), so I honestly don't see which advantages would be by reimplementing it. > (I realize that xfs has separate iomap operations for xattrs, but that > is only used in its fiemap implementation.) > > Thanks, > Andreas -- Carlos