Re: [PATCH v2 2/5] fsnotify: annotate filename events

[Amir Goldstein <amir73il@xxxxxxxxx>]

> > @@ -85,8 +108,8 @@ static inline void fsnotify_move(struct inode *old_dir, struct inode *new_dir,
> >  {
> >       struct inode *source = moved->d_inode;
> >       u32 fs_cookie = fsnotify_get_cookie();
> > -     __u32 old_dir_mask = (FS_EVENT_ON_CHILD | FS_MOVED_FROM);
> > -     __u32 new_dir_mask = (FS_EVENT_ON_CHILD | FS_MOVED_TO);
> > +     __u32 old_dir_mask = FS_MOVED_FROM;
> > +     __u32 new_dir_mask = FS_MOVED_TO;
>
> You can just inline these two masks now. There's no point for the variable
> anymore.
>

He? why not?
We still this this:

        if (old_dir == new_dir)
                old_dir_mask |= FS_DN_RENAME;

        if (isdir) {
                old_dir_mask |= FS_ISDIR;
                new_dir_mask |= FS_ISDIR;
        }

@isdir refers to the d_type of the modified dirent.

Thanks,
Amir.