On Tue, Nov 6, 2018 at 10:25 AM, Kirill Tkhai <ktkhai@xxxxxxxxxxxxx> wrote: > On 06.11.2018 12:23, Miklos Szeredi wrote: >> On Tue, Nov 6, 2018 at 10:13 AM, Kirill Tkhai <ktkhai@xxxxxxxxxxxxx> wrote: >>> fuse_request_send_notify_reply() may fail, and this case >>> it remains leaked (fuse_retrieve_end(), which is called >>> on error path, does not do that). Also, fc->num_waiting, >>> will never be decremented, and fuse_wait_aborted() will >>> never finish. So, put the request patently. >>> >>> Signed-off-by: Kirill Tkhai <ktkhai@xxxxxxxxxxxxx> >> >> Posted same patch yesterday for a syzbot report. How did you notice this? > > I've found this by code review. I did this last week and I have 10 patches more > on different theme. I was waiting for when the merge window opens. Well, the merge window just closed. But never worry, bugfixes can go in at anytime. If you notice a bug, such as this, you don't need to hold back until any particular time, the sooner it's known, the better. Thanks, Miklos
