On Wed, Oct 24, 2018 at 12:56 PM Phillip Potter <phil@xxxxxxxxxxxxxxxx> wrote: > > On Wed, Oct 24, 2018 at 12:44:50PM +0300, Amir Goldstein wrote: ... > > Well, I did request to change some content (the location and the comment > > above BUILD_BUG_ON section) which is relevant for several patches. > > However, so far affected patched did not get any Reviewed-by. > > > > Thanks, > > Amir. > > Sorry, I missed that bit at the end, was too keen to click through to the > note about the alleged ext2 bug :-) I will make sure those changes are made > as well. By location do you mean the location of the v3, v2, etc. stuff and > your point about including it in the main [0/10] message rather than the > patches themselves? Again, thank you for your feedback and for being patient > with me, I really do appreciate it. > By location I meant place BUILD_BUG_ON() at the beginning of ext2_set_de_type() and not nested inside inner scope of ext2_readdir(). And find similar appropriate places for other patches. And one more thing for next posting - LKML is probably a too wide forum for this filesystems cleanup series. Cheers, Amir.