On Wed, Oct 24, 2018 at 09:16:20AM +0300, Amir Goldstein wrote: > On Tue, Oct 23, 2018 at 11:19 PM Phillip Potter <phil@xxxxxxxxxxxxxxxx> wrote: > > > > Many file systems use a copy&paste implementation > > of dirent to on-disk file type conversions. > > > > Create a common implementation to be used by file systems > > with some useful conversion helpers to reduce open coded > > file type conversions in file system code. > > > > Original patch written by Amir Goldstein. > > Looks good. > I guess you used 'git apply' or just 'patch' > What you usually do when applying someone else mostly unchanged > patches is use 'git am -s -3' so you preserve the original author and > original commit message including the Signed-of-by line. > You can edit your patch by hand to change the From: line to change the > author and add > Signed-off-by: Amir Goldstein <amir73il@xxxxxxxxx> > (you sign below me as you changed the patch last) > Dear Amir, Yes, I applied each patch manually to my tree, fixed it up where needed, then after rebuilding and testing each one I committed it and regenerated each patch. Thank you very much for your advice, I will take it into account and make the necessary changes. In the meantime, do I add other tags in the order they are received also (such as Reviewed-by:) and am I safe to add these in when I re-send the patches with the changes you and others have suggested (or would that offend people that have offered the tags)? Regards, Phil
