On Tue, 2018-09-11 at 17:27 +0200, Jan Kara wrote: > On Mon 10-09-18 17:58:10, Elliott, Robert (Persistent Memory) wrote: > > > > > > > -----Original Message----- > > > From: Linux-nvdimm [mailto:linux-nvdimm-bounces@xxxxxxxxxxxx] On Behalf Of Kani, Toshi > > > Sent: Monday, September 10, 2018 9:52 AM > > > To: jack@xxxxxxx > > > Cc: linux-fsdevel@xxxxxxxxxxxxxxx; linux-nvdimm@xxxxxxxxxxxx > > > Subject: Re: open sets ext4_da_aops for DAX existing files > > > > ... > > > > Good catch. Will you send a fix? I.e., call ext4_set_inode_flags() earlier > > > > in the ext4_iget()? Did this bug have any user visible manifestations? > > > > > > Yes, sync did not flush processor cache. > > > > > > > Please also add: > > > > > > > > Fixes: 5f0663bb4a64f588f0a2dd6d1be68d40f9af0086 > > > > > > > > so that stable automation picks this up. Thanks! > > > > > > > > > > Will do. > > > > > > > Also check if the same problem exists with ext2. > > The problem also exists in ext2 so that needs fixing as well. Right. Once my ext4 patch 2/2 is reviewed, I will duplicate it for ext2. Thanks, -Toshi
