On Mon, 2018-09-10 at 16:29 +0200, Jan Kara wrote: > On Fri 07-09-18 21:23:19, Kani, Toshi wrote: > > I noticed that both ext4_da_aops and ext4_dax_aops are used on DAX > > mounted ext4 files. Looking at open() path: > > > > New file > > -------- > > lookup_open > > ext4_create > > __ext4_new_inode > > ext4_set_inode_flags // Set S_DAX flag > > ext4_set_aops // Set aops to ext4_dax_aops > > > > Existing file > > ------------- > > lookup_open > > ext4_lookup > > ext4_iget > > ext4_set_aops // Set aops to ext4_da_aops > > ext4_set_inode_flags // Set S_DAX flag > > > > So, we set ext4_da_aops for existing files since S_DAX flag is set after > > ext4_set_aops(). > > Good catch. Will you send a fix? I.e., call ext4_set_inode_flags() earlier > in the ext4_iget()? Did this bug have any user visible manifestations? Yes, sync did not flush processor cache. > Please also add: > > Fixes: 5f0663bb4a64f588f0a2dd6d1be68d40f9af0086 > > so that stable automation picks this up. Thanks! > Will do. Thanks, -Toshi
