On Tue, Jul 10, 2018 at 07:39:07PM -0700, Linus Torvalds wrote:
> On Tue, Jul 10, 2018 at 7:23 PM Al Viro <viro@xxxxxxxxxxxxxxxxxx> wrote:
> >
> >
> > cleanup_all:
> > + if (unlikely(error > 0)) {
> > + WARN_ON(1);
> > + error = -EINVAL;
> > + }
>
> Can we please do this as
>
> if (WARN_ON_ONCE(error > 0))
> error = -EINVAL;
>
>
> instead?
>
> That already should do the unlikely for you, and *if* somebody can
> trigger this, at least they won't be spamming the logs and making a
> mess. A single warning is fine.
No problem, will do...
