On 6/1/18 9:38 AM, Adam Manzanares wrote: > On 5/31/18 10:13 PM, Christoph Hellwig wrote: >>> +extern int ioprio_check_cap(int ioprio); >> >> Which then is implemented in block/ioprio.c, which depends on >> CONFIG_BLOCK. The code either needs a stub for !CONFIG_BLOCK >> or moved elsewhere. > > My vote would be to move the ioprio code into fs/. At first glance I do > not see a dependence on the block layer in block/ioprio.c. > > Any objections? Since it's block ioprio code, I'd prefer a stub instead. -- Jens Axboe