Re: [vfs:work.aio 10/12] fs/aio.c:1444: undefined reference to `ioprio_check_cap'

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Christoph Hellwig <hch@xxxxxx>, Al Viro <viro@xxxxxxxxxxxxxxxxxx>, Jens Axboe <axboe@xxxxxxxxx>
Subject: Re: [vfs:work.aio 10/12] fs/aio.c:1444: undefined reference to `ioprio_check_cap'
From: Adam Manzanares <Adam.Manzanares@xxxxxxx>
Date: Fri, 1 Jun 2018 15:38:45 +0000
Accept-language: en-US
Cc: kbuild test robot <lkp@xxxxxxxxx>, "kbuild-all@xxxxxx" <kbuild-all@xxxxxx>, "linux-fsdevel@xxxxxxxxxxxxxxx" <linux-fsdevel@xxxxxxxxxxxxxxx>, Jeff Moyer <jmoyer@xxxxxxxxxx>
In-reply-to: <20180601051353.GA21589@lst.de>
Thread-index: AQHT+b6gcP8N8zWZFESWaweg3Opc3A==
Thread-topic: [vfs:work.aio 10/12] fs/aio.c:1444: undefined reference to `ioprio_check_cap'
Wdcipoutbound: EOP-TRUE

My vote would be to move the ioprio code into fs/. At first glance I do 
not see a dependence on the block layer in block/ioprio.c.

Any objections?

On 5/31/18 10:13 PM, Christoph Hellwig wrote:
>> +extern int ioprio_check_cap(int ioprio);
> 
> Which then is implemented in block/ioprio.c, which depends on
> CONFIG_BLOCK.  The code either needs a stub for !CONFIG_BLOCK
> or moved elsewhere.
>

Follow-Ups:
- Re: [vfs:work.aio 10/12] fs/aio.c:1444: undefined reference to `ioprio_check_cap'
  - From: Jens Axboe

References:
- [vfs:work.aio 10/12] fs/aio.c:1444: undefined reference to `ioprio_check_cap'
  - From: kbuild test robot
- Re: [vfs:work.aio 10/12] fs/aio.c:1444: undefined reference to `ioprio_check_cap'
  - From: Al Viro
- Re: [vfs:work.aio 10/12] fs/aio.c:1444: undefined reference to `ioprio_check_cap'
  - From: Christoph Hellwig

Prev by Date: Re: [GIT PULL] overlayfs update for 4.18
Next by Date: Re: [vfs:work.aio 10/12] fs/aio.c:1444: undefined reference to `ioprio_check_cap'
Previous by thread: Re: [vfs:work.aio 10/12] fs/aio.c:1444: undefined reference to `ioprio_check_cap'
Next by thread: Re: [vfs:work.aio 10/12] fs/aio.c:1444: undefined reference to `ioprio_check_cap'
Index(es):
- Date
- Thread

[Index of Archives] [Linux Ext4 Filesystem] [Union Filesystem] [Filesystem Testing] [Ceph Users] [Ecryptfs] [AutoFS] [Kernel Newbies] [Share Photos] [Security] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux Cachefs] [Reiser Filesystem] [Linux RAID] [Samba] [Device Mapper] [CEPH Development]