On Wed, May 9, 2018 at 10:13 PM, Goldwyn Rodrigues <rgoldwyn@xxxxxxx> wrote: > > > On 05/09/2018 12:50 AM, Amir Goldstein wrote: >> On Wed, May 9, 2018 at 12:24 AM, Goldwyn Rodrigues <rgoldwyn@xxxxxxx> wrote: >>> From: Goldwyn Rodrigues <rgoldwyn@xxxxxxxx> >>> >>> This will preserve the holes and will clone(), if available. >>> >>> Signed-off-by: Goldwyn Rodrigues <rgoldwyn@xxxxxxxx> >> Reviewed-by: Amir Goldstein <amir73il@xxxxxxxxx> >> >> Only please mention in commit message that it changes behavoir >> slightly for a very large file (clone in chunks). > > Change behavior? Only it will have holes. It will still respect length. > Actually, I found a bug when it would not respect length if offset is > father than length which I have fixed. What I meant is the change of behavior for when underlying fs supports clone. Your patch changes the behavior for a very large file from single call to vfs_clone_file_range() on entire length to several calls in a loop. Nevermind. It's too insignificant for anyone to care. If overlayfs ever supports NFS as upper layer, we may want to rethink this. Thanks, Amir.
