On Wed, May 9, 2018 at 12:24 AM, Goldwyn Rodrigues <rgoldwyn@xxxxxxx> wrote: > From: Goldwyn Rodrigues <rgoldwyn@xxxxxxxx> > > This will preserve the holes and will clone(), if available. > > Signed-off-by: Goldwyn Rodrigues <rgoldwyn@xxxxxxxx> Reviewed-by: Amir Goldstein <amir73il@xxxxxxxxx> Only please mention in commit message that it changes behavoir slightly for a very large file (clone in chunks). I see no problem with this change. And please test with xfstest overlay/001 with copies up a large sparse file. test time should drop from ~30s to 0s. If you like I can test that one for you. I believe there are also generic copy_file_range tests in xfstests. Thanks, Amir.
