On Thu, Apr 19, 2018 at 3:41 PM, Jan Kara <jack@xxxxxxx> wrote: > On Fri 06-04-18 14:04:23, Amir Goldstein wrote: >> On Fri, Apr 6, 2018 at 9:01 AM, kbuild test robot <lkp@xxxxxxxxx> wrote: >> > Hi Amir, >> > >> > I love your patch! Yet something to improve: >> >> Thank you robot :) >> >> > >> > [auto build test ERROR on v4.16] >> > [cannot apply to linus/master next-20180405] >> > [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] >> > >> > url: https://github.com/0day-ci/linux/commits/Amir-Goldstein/fanotify-super-block-mark/20180406-132931 >> > config: i386-tinyconfig (attached as .config) >> > compiler: gcc-7 (Debian 7.3.0-1) 7.3.0 >> > reproduce: >> > # save the attached .config to linux build tree >> > make ARCH=i386 >> > >> > All errors (new ones prefixed by >>): >> > >> > In file included from fs//attr.c:15:0: >> > include/linux/fsnotify.h: In function 'fsnotify_sb_delete': >> >>> include/linux/fsnotify.h:122:2: error: implicit declaration of function '__fsnotify_sb_delete'; did you mean 'fsnotify_sb_delete'? [-Werror=implicit-function-declaration] >> > __fsnotify_sb_delete(sb); >> > ^~~~~~~~~~~~~~~~~~~~ >> > fsnotify_sb_delete >> > cc1: some warnings being treated as errors >> > >> > vim +122 include/linux/fsnotify.h >> > >> > 116 >> > 117 /* >> > 118 * fsnotify_sb_delete - a super block is being destroyed, clean up is needed >> > 119 */ >> > 120 static inline void fsnotify_sb_delete(struct super_block *sb) >> > 121 { >> > > 122 __fsnotify_sb_delete(sb); >> > 123 } >> > 124 >> > >> >> Jan, >> >> What do you think about ifdefing away everything in fsnotify.h >> for CONFIG_FSNOTIFY=n? > > I'm fine with that but I suspect you'll then have to define empty stubs for > the stuff defined in fsnotify.h when CONFIG_FSNOTIFY=n, won't you? > Yes, I though that will be cleaner - zero footprint of fsnotify for CONFIG_FSNOTIFY=n, but now I realize that audit_inode_child() piggy backs on the fsnotify_ hooks and CONFIG_AUDIT is independent of CONFIG_FSNOTIFY, so I will just get rid of __fsnotify_sb_delete() as you suggested. Thanks, Amir.
