On Thu 05-04-18 16:18:18, Amir Goldstein wrote: > @@ -98,6 +98,12 @@ void fsnotify_unmount_inodes(struct super_block *sb) > iput(iput_inode); > } > > +void __fsnotify_sb_delete(struct super_block *sb) > +{ > + fsnotify_unmount_inodes(sb); > + fsnotify_clear_marks_by_sb(sb); > +} > + I think it is pointless to have fsnotify_sb_delete() and __fsnotify_sb_delete(). I know some other fsnotify API is like that and I'm slowly trying to get rid of that overabstraction. Just make this fsnotify_sb_delete() directly. Honza -- Jan Kara <jack@xxxxxxxx> SUSE Labs, CR