We discovered some problems in the latest fsnotify/fanotify codebase with the help of a stress test (Xiong Zhou is working on upstreaming it to fstests). This series attempts to fix these. With the patch applied the stress test passes. Please review/test. Changes in v2 (only cosmetic fixes, no functional change): - split first patch into 3 parts to make it more readable - checkpatch fixes - added cleanup patch for fanotify Thanks, Miklos --- Miklos Szeredi (7): fsnotify: clean up fsnotify_prepare/finish_user_wait() fsnotify: pin both inode and vfsmount mark fsnotify: fix pinning group in fsnotify_prepare_user_wait() fsnotify: skip unattached marks fanotify: fix fsnotify_prepare_user_wait() failure fsnotify: clean up fsnotify() fanotify: clean up CONFIG_FANOTIFY_ACCESS_PERMISSIONS ifdefs fs/notify/fanotify/fanotify.c | 49 ++++++--------- fs/notify/fanotify/fanotify.h | 8 ++- fs/notify/fanotify/fanotify_user.c | 123 ++++++++++++++++++------------------- fs/notify/fsnotify.c | 108 ++++++++++++++++---------------- fs/notify/mark.c | 100 ++++++++++++++---------------- include/linux/fsnotify_backend.h | 2 - 6 files changed, 184 insertions(+), 206 deletions(-) -- 2.5.5