The first patch is a super minor nit and I'm fine with it being ignored. Second patch is imho of actual value. fd_install has an avoidable requirement to be called in a sleepable context. It matters e.g. in rhel7 to where the patch was recently backported and the new requirement could not be enforced. I don't see any benefits from sleeping over locking and not sleeping makes the function slightly nicer. Mateusz Guzik (2): vfs: stop clearing close on exec when closing a fd vfs: grab the lock instead of blocking in __fd_install during resizing Documentation/filesystems/porting | 4 ---- fs/file.c | 12 +++++++----- 2 files changed, 7 insertions(+), 9 deletions(-) -- 1.8.3.1