On 2017/7/18 0:55, Jaegeuk Kim wrote:
> On 07/17, Chao Yu wrote:
>> Hi Jaegeuk,
>>
>> On 2017/7/14 9:01, Jaegeuk Kim wrote:
>>> This patch includes seq_file.h to avoid compile error.
>>
>> I didn't hit the error, I guess that's because we have included f2fs_fs.h
>> in sysfs.c, the inclusion relation is like this:
>> - sysfs.c
>> - f2fs_fs.h
>> - pagemap.h
>> - fs.h
>> - struct seq_file
>
> What about seq ops such as seq_puts?
- sysfs.c
- segment.h
- linux/backing-dev.h
- linux/writeback.h
#ifdef CONFIG_CGROUP_WRITEBACK
- linux/cgroup.h
- linux/seq_file.h
#endif
So it looks that there is no compiling error in my environment because
of CONFIG_CGROUP_WRITEBACK was defined.
Anyway, please add:
Reviewed-by: Chao Yu <yuchao0@xxxxxxxxxx>
Thanks,
>
> Thanks,
>
>>
>> Thanks,
>>
>>>
>>> Signed-off-by: Eric Biggers <ebiggers@xxxxxxxxxx>
>>> Signed-off-by: Jaegeuk Kim <jaegeuk@xxxxxxxxxx>
>>> ---
>>> fs/f2fs/sysfs.c | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/fs/f2fs/sysfs.c b/fs/f2fs/sysfs.c
>>> index 9adc202fcd6f..71191d89917d 100644
>>> --- a/fs/f2fs/sysfs.c
>>> +++ b/fs/f2fs/sysfs.c
>>> @@ -11,6 +11,7 @@
>>> */
>>> #include <linux/proc_fs.h>
>>> #include <linux/f2fs_fs.h>
>>> +#include <linux/seq_file.h>
>>>
>>> #include "f2fs.h"
>>> #include "segment.h"
>>>
>
> .
>
