On 06/27/2017 08:42 AM, Christoph Hellwig wrote: > The API looks ok, but the code could use some cleanups. What do > you think about the incremental patch below: > > It refactors various manipulations, and stores the write hint right > in the iocb as there is a 4 byte hole (this will need some minor > adjustments in the next patches): Sigh... Sure, that's how I did it originally as well. BTW, that patch does not look like an incremental patch, what's this against? -- Jens Axboe