On Tue, Jun 27, 2017 at 07:42:55AM -0700, Christoph Hellwig wrote: > The API looks ok, but the code could use some cleanups. What do > you think about the incremental patch below: > > It refactors various manipulations, and stores the write hint right > in the iocb as there is a 4 byte hole (this will need some minor > adjustments in the next patches): And looking over the followons I'd love to just store the hints directly in the inode, bio and request themselves. We have big enough holes at least in the bio and request to store them, although instead of the enum which is at least in sized we'd have to make them an explicit u16 or even u8.
