Miklos Szeredi <mszeredi@xxxxxxxxxx> wrote: > So say we have commands like > > "o+ foo" > "o- bar" The convention seems to be to prepend "no" to things you want to disable, so let's stick with that, e.g.: "o foo" "o nobar" otherwise we will have to have separate parsers for old mount() and the new sb config code - and not just for NFS, but at least for ext2/3/4 also. Further, we can only publish one format in /proc/mounts - and we cannot change that from the foo/nofoo standard we already use as it's part of the UAPI. > The generic option parser would just add or remove the option in the > current set of options, It sounds like you want to build up a string of "opt1,opt2,opt3" then have the VFS add and remove things from it and then parse it into the filesystem's internal structures on "commit". > and commit would just call ->remount_fs() with the new set of options. You're defining "commit" to do different things depending on the situation. You need a separation between "commit create" and "commit update". > It would probably not work for the NFS case, but that's okay, NFS can > implement its own option parsing. If NFS has to implement its own option parsing, we've done it wrong. David
