Am 09.05.2017 um 11:02 schrieb Christoph Hellwig: > On Fri, May 05, 2017 at 01:20:11PM +0300, Amir Goldstein wrote: >> Seriously, one has to do things in certain order. > > Yes… and I want to ensure that order. > >> There is no reason to wait for the common uuid code to settle down before >> fixing something as trivial as this and it makes very little sense IMO to use >> uuid_be_gen() for sb->s_uuid as it is now. > > There is. generate_random_uuid needs to die, and adding more callers > isn't the way to go. Same for ubifs btw. I agree. Right now UBIFS uses generate_random_uuid() in both kernel and mkfs.ubifs. Before we expose it to ->s_uuid, UBIFS should use the correct UUID generation functions. Oleksij, please follow this discussion before you re-send your UBIFS patch. Thanks, //richard
