Re: [PATCH v2 7/8] linux/uuid.h: hoist uuid_is_null() helper from libnvdimm

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Amir Goldstein <amir73il@xxxxxxxxx>
Subject: Re: [PATCH v2 7/8] linux/uuid.h: hoist uuid_is_null() helper from libnvdimm
From: Christoph Hellwig <hch@xxxxxx>
Date: Thu, 4 May 2017 15:30:12 +0200
Cc: "Darrick J . Wong" <darrick.wong@xxxxxxxxxx>, Christoph Hellwig <hch@xxxxxx>, Miklos Szeredi <miklos@xxxxxxxxxx>, Theodore Tso <tytso@xxxxxxx>, Richard Weinberger <richard@xxxxxx>, Mark Fasheh <mfasheh@xxxxxxxxxxx>, Dan Williams <dan.j.williams@xxxxxxxxx>, Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>, David Howells <dhowells@xxxxxxxxxx>, Shaohua Li <shli@xxxxxxxxxx>, Al Viro <viro@xxxxxxxxxxxxxxxxxx>, linux-xfs@xxxxxxxxxxxxxxx, linux-unionfs@xxxxxxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx
In-reply-to: <1493904383-2187-8-git-send-email-amir73il@gmail.com>
User-agent: Mutt/1.5.17 (2007-11-01)

> -	if (!uuid_is_null(super->parent_uuid))
> +	if (!uuid_is_null((uuid_t *)super->parent_uuid))

No strange casts please, change parent_uuid to be an actual uuid_t
instead.

References:
- [PATCH v2 0/8] hoist uuid helpers from xfs to linux/uuid.h
  - From: Amir Goldstein
- [PATCH v2 7/8] linux/uuid.h: hoist uuid_is_null() helper from libnvdimm
  - From: Amir Goldstein

Prev by Date: Re: [PATCH v2 4/8] xfs: namespace the helper uuid_getnodeuniq()
Next by Date: Re: [PATCH v2 1/8] xfs: use uuid_copy() helper to abstract uuid_t
Previous by thread: [PATCH v2 7/8] linux/uuid.h: hoist uuid_is_null() helper from libnvdimm
Next by thread: [PATCH v2 8/8] xfs: use the common helper uuid_is_null()
Index(es):
- Date
- Thread

[Index of Archives] [Linux Ext4 Filesystem] [Union Filesystem] [Filesystem Testing] [Ceph Users] [Ecryptfs] [AutoFS] [Kernel Newbies] [Share Photos] [Security] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux Cachefs] [Reiser Filesystem] [Linux RAID] [Samba] [Device Mapper] [CEPH Development]