On Wed, May 03, 2017 at 11:26:38AM -0700, Joe Perches wrote: > On Wed, 2017-05-03 at 14:13 -0400, Jeff Layton wrote: > > On Wed, 2017-05-03 at 17:04 +0100, David Howells wrote: > > > + oo = kmalloc((opts->num_mnt_opts + 1) * sizeof(char *), > > > + GFP_KERNEL); If we're picking nits, then this should be kcalloc in case somebody passed in 2^31 in num_mnt_opts.