On Wed, Apr 26, 2017 at 11:27 AM, Amir Goldstein <amir73il@xxxxxxxxx> wrote: > > The offset argument is discard-able, it gives you more information > than we need. Sure, the problem with that is what should a filesystem put there which cannot provide such an offset? Is it optional? What value indicates invalid offset? > Another problem is that ->get_uuid for xfs is compiled out by default > without CONFIG_PNFSD, although this could be changed. > > Anyway, I have a very simple patch for xfs to set sb->s_uuid. > btrfs has several uuid's (i.e. subvolumes) on the same sb struct IIUC, > so need to see how to handle this. Yes, actually btrfs wants some sort of lightweight superblock for subvolumes with just s_dev and s_uuid. Not sure what we can do about that for now... Thanks, Miklos
