On Mon, Mar 27, 2017 at 6:00 AM, David Howells <dhowells@xxxxxxxxxx> wrote: > Eric Sandeen <sandeen@xxxxxxxxxxx> wrote: > >> These 2 patches are a second pass to add a statx command >> to xfs_io in hopes that it will aid creation of xfstests >> statx regression tests. > > Would it be possible to redirect all the stat() calls made by xfstests to > statx() with translation of the output buffer back to struct stat? > David, xfstests is all 99% bash scripts and most of the uses of stat(2) are by executing stat(1), so all you have to do in order to exercise a statx() with existing tests is install a stat executable in your path that uses statx() instead of stat(). For that purpose, the xfs_io patch does not really help you because it does not provide the stat -c output formatting options, which the tests expect. This may not be enough long term, but it could be a nice validation. xfs_io -c statx would be useful to write new xfstests that exercise statx specifically. It sounds like you are new to xfstests? What you probably want to run is ./check -g quick. xfstests is not extensively documented, but it quite simple, so it usually "just works". Let us know if you have troubles staring up. Cheers, Amir.
