On Mon, Mar 27, 2017 at 12:47:33PM -0500, Eric Sandeen wrote: > On 3/27/17 5:00 AM, David Howells wrote: > > Eric Sandeen <sandeen@xxxxxxxxxxx> wrote: > > > >> These 2 patches are a second pass to add a statx command > >> to xfs_io in hopes that it will aid creation of xfstests > >> statx regression tests. > > > > Would it be possible to redirect all the stat() calls made by xfstests to > > statx() with translation of the output buffer back to struct stat? > > I'm sure LD_PRELOAD tricks could do that, but it'd be a little unusual > for xfstests, at least - kind of a side hack that's not really expected > and therefore wouldn't get consistently run. > > Honestly, just write a bash script for xfstests which tests expected > statx behavior for various inputs, verifies what it can against stat, > and it's all good... Don't forget to add it to fsstress and randomise the flag values it uses... Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx