On Tue, Feb 14, 2017 at 08:46:32PM +1300, Eric W. Biederman wrote: > All of that said where are you getting sb->s_user_ns != &init_user_ns > for an xfs filesystem? There are quite a few xfs interfaces that are > not ready for that. xfs has a very wide userspace interface of ioctls > that all needs to be looked at and addressed carefully if there is > anything like this going on. The only thing exposing uids/gid is the bulkstat code, and that's easy to cover. > > +/* return the current id in the filesystem view */ > > +#define i_fsuid(i) from_kuid((i)->i_sb->s_user_ns, current_fsuid()) > > +#define i_fsgid(i) from_kgid((i)->i_sb->s_user_ns, current_fsgid()) > > Could we please place these helpers in fs.h? > That should allow them to become inline functions and live with the > existing filesystem helpers in there. And give them better names, i_* is rather cryptic.
