On Mon, Feb 13, 2017 at 11:43:37AM -0800, Christoph Hellwig wrote:
> --- a/fs/xfs/xfs_inode.c
> +++ b/fs/xfs/xfs_inode.c
> @@ -814,18 +814,10 @@ xfs_ialloc(
> if (ip->i_d.di_version == 1)
> ip->i_d.di_version = 2;
>
> - inode->i_mode = mode;
> + inode_init_owner(inode, pip ? VFS_I(pip) : NULL, mode);
> set_nlink(inode, nlink);
> - ip->i_d.di_uid = xfs_kuid_to_uid(current_fsuid());
> - ip->i_d.di_gid = xfs_kgid_to_gid(current_fsgid());
> xfs_set_projid(ip, prid);
>
> - if (pip && XFS_INHERIT_GID(pip)) {
> - ip->i_d.di_gid = pip->i_d.di_gid;
> - if ((VFS_I(pip)->i_mode & S_ISGID) && S_ISDIR(mode))
> - inode->i_mode |= S_ISGID;
> - }
> -
Doesn't this hunk break the "nogrpid" mount option?
Cheers,
Dave.
--
Dave Chinner
david@xxxxxxxxxxxxx
